2 years agobumped version to 2.0.1
Michael Rash [Tue, 24 Jul 2012 02:40:47 +0000]
bumped version to 2.0.1

2 years agobumped version to fwknop-2.0.1
Michael Rash [Tue, 24 Jul 2012 01:58:14 +0000]
bumped version to fwknop-2.0.1

2 years agoremoved diffstat and ShortLog files in favor of ChangeLog.git for each release
Michael Rash [Tue, 24 Jul 2012 01:54:49 +0000]
removed diffstat and ShortLog files in favor of ChangeLog.git for each release

2 years agoupdated Debian init script (contributed by Franck Joncourt)
Michael Rash [Tue, 24 Jul 2012 01:49:25 +0000]
updated Debian init script (contributed by Franck Joncourt)

2 years agoadd test/conf/local_nat_fwknopd.conf for 'make dist' fwknop-2.0.1-pre5
Michael Rash [Tue, 24 Jul 2012 01:32:24 +0000]
add test/conf/local_nat_fwknopd.conf for 'make dist'

2 years agobumped version to fwknop-2.0.1-pre5
Michael Rash [Tue, 24 Jul 2012 01:24:29 +0000]
bumped version to fwknop-2.0.1-pre5

2 years ago[client] fix memory leak when unable to open --get-key file
Michael Rash [Tue, 24 Jul 2012 01:23:23 +0000]
[client] fix memory leak when unable to open --get-key file

2 years agoPCAP_LOOP_SLEEP bug fix to 1/10th of a second
Michael Rash [Tue, 24 Jul 2012 01:13:30 +0000]
PCAP_LOOP_SLEEP bug fix to 1/10th of a second

[server] Updated PCAP_LOOP_SLEEP default to 1/10th of a second (in
microseconds).  This was supposed to be the default anyway, but C
Anthony Risinger reported a bug where fwknopd was consuming more
resources than necessary, and the cause was PCAP_LOOP_SLEEP set by
default to 1/100th of a second - this has been fixed.

2 years agoreplace strlen() calls with strnlen() and appropriate maximums
Michael Rash [Mon, 23 Jul 2012 03:13:39 +0000]
replace strlen() calls with strnlen() and appropriate maximums

2 years agouse LOGNAME env var before cuserid() since we're already looking for SPOOF_USER
Michael Rash [Mon, 23 Jul 2012 03:13:01 +0000]
use LOGNAME env var before cuserid() since we're already looking for SPOOF_USER

2 years ago[client] Fixed several minor memory leaks caught by valgrind
Michael Rash [Mon, 23 Jul 2012 03:09:32 +0000]
[client] Fixed several minor memory leaks caught by valgrind

This commit fixes memory leaks like the following in the fwknop client:

    in use at exit: 300 bytes in 11 blocks
  total heap usage: 100 allocs, 89 frees, 16,583 bytes allocated

16 bytes in 1 blocks are indirectly lost in loss record 1 of 11
   at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
   by 0x5146C59: __nss_lookup_function (nsswitch.c:456)
   by 0x5C3D63E: ???
   by 0x50FF3FC: getpwuid_r@@GLIBC_2.2.5 (getXXbyYY_r.c:256)
   by 0x508938E: cuserid (cuserid.c:37)
   by 0x4E3983A: fko_set_username (fko_user.c:65)
   by 0x4E38D5C: fko_new (fko_funcs.c:84)
   by 0x10A824: main (fwknop.c:75)

16 bytes in 1 blocks are indirectly lost in loss record 2 of 11
   at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
   by 0x5146C59: __nss_lookup_function (nsswitch.c:456)
   by 0x5C3D658: ???
   by 0x50FF3FC: getpwuid_r@@GLIBC_2.2.5 (getXXbyYY_r.c:256)
   by 0x508938E: cuserid (cuserid.c:37)
   by 0x4E3983A: fko_set_username (fko_user.c:65)
   by 0x4E38D5C: fko_new (fko_funcs.c:84)
   by 0x10A824: main (fwknop.c:75)

16 bytes in 1 blocks are indirectly lost in loss record 3 of 11
   at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
   by 0x5146C59: __nss_lookup_function (nsswitch.c:456)
   by 0x5C3D672: ???
   by 0x50FF3FC: getpwuid_r@@GLIBC_2.2.5 (getXXbyYY_r.c:256)
   by 0x508938E: cuserid (cuserid.c:37)
   by 0x4E3983A: fko_set_username (fko_user.c:65)
   by 0x4E38D5C: fko_new (fko_funcs.c:84)
   by 0x10A824: main (fwknop.c:75)

16 bytes in 1 blocks are indirectly lost in loss record 4 of 11
   at 0x4C2B6CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
   by 0x5146C59: __nss_lookup_function (nsswitch.c:456)
   by 0x5C3D68C: ???
   by 0x50FF3FC: getpwuid_r@@GLIBC_2.2.5 (getXXbyYY_r.c:256)
   by 0x508938E: cuserid (cuserid.c:37)
   by 0x4E3983A: fko_set_username (fko_user.c:65)
   by 0x4E38D5C: fko_new (fko_funcs.c:84)
   by 0x10A824: main (fwknop.c:75)

2 years agoBetter SPA message validation upon SPA decrypt/decode.
Michael Rash [Sat, 21 Jul 2012 19:32:15 +0000]
Better SPA message validation upon SPA decrypt/decode.

Added SPA message validation calls to fko decoding routines to help
ensure that SPA messages conform to expected values.

2 years ago[test suite] minor filename update -> use config files for fwknopd in a hash
Michael Rash [Sat, 21 Jul 2012 01:16:13 +0000]
[test suite] minor filename update -> use config files for fwknopd in a hash

2 years agoImplemented server-side bounds checking on inccoming SPA data.
Michael Rash [Fri, 20 Jul 2012 02:34:45 +0000]
Implemented server-side bounds checking on inccoming SPA data.

Enhanced the libfko decoding routine to include bounds checking on decrypted
SPA data.  This includes verifying the number of fields within incoming SPA
data (colon separated) along with verifying string lengths of each field.

2 years agoadded some integer bounds checking for fwknopd.conf variables
Michael Rash [Thu, 19 Jul 2012 03:20:09 +0000]
added some integer bounds checking for fwknopd.conf variables

2 years agominor update to print FORCE_NAT settings when access stanzas are printed
Michael Rash [Thu, 19 Jul 2012 03:17:27 +0000]
minor update to print FORCE_NAT settings when access stanzas are printed

2 years agominor pcap_capture update to not call atoi() against PCAP_LOOP_SLEEP for every sleep...
Michael Rash [Thu, 19 Jul 2012 03:00:58 +0000]
minor pcap_capture update to not call atoi() against PCAP_LOOP_SLEEP for every sleep interval

2 years ago[test suite] minor hostname bugfix to get 'local NAT' test to work
Michael Rash [Thu, 19 Jul 2012 02:55:56 +0000]
[test suite] minor hostname bugfix to get 'local NAT' test to work

2 years ago[test suite] better fwknopd is running check
Michael Rash [Thu, 19 Jul 2012 02:32:16 +0000]
[test suite] better fwknopd is running check

2 years agoMerge branch 'master' of github.com:mrash/fwknop
Michael Rash [Wed, 18 Jul 2012 02:20:36 +0000]
Merge branch 'master' of github.com:mrash/fwknop

2 years ago[test suite] file_find_regex() postive vs. negative match styles
Michael Rash [Wed, 18 Jul 2012 01:55:13 +0000]
[test suite] file_find_regex() postive vs. negative match styles

Positive match style requires all regex's to be found, whereas negative match
style only requires seeing one regex.

2 years agoEnsure that INPUT rules are added in --nat-local mode
Michael Rash [Wed, 18 Jul 2012 01:50:29 +0000]
Ensure that INPUT rules are added in --nat-local mode

This change ensures that INPUT rules are added when the fwknop client is used to
request access to a local service with --nat-local mode.

2 years agominor file_find_regex() logging prefix update
Michael Rash [Tue, 17 Jul 2012 02:05:15 +0000]
minor file_find_regex() logging prefix update

2 years ago[test suite] added local_nat_fwknopd.conf file for local NAT tests
Michael Rash [Tue, 17 Jul 2012 01:43:28 +0000]
[test suite] added local_nat_fwknopd.conf file for local NAT tests

2 years agoAdd INPUT ACCEPT rule for --nat-local connections
Michael Rash [Mon, 16 Jul 2012 01:32:14 +0000]
Add INPUT ACCEPT rule for --nat-local connections

When using the --nat-local argument on the fwknop client command line, the
fwknopd server needs to add an INPUT ACCEPT rule for the requested access
since the incoming connection is destined for a local socket.  Added test
suite support to test --nat-local access.

[test suite] Minor bug fix to ensure that all file_find_regex() calls return
true if all regex's are matched and false if any regex does not match data in
the specified file.

2 years agoForgot to update the VERSION file. fwknop-2.0.1-pre4
Damien Stuart [Sun, 15 Jul 2012 02:10:37 +0000]
Forgot to update the VERSION file.

2 years agoBumped version to 2.0.1-pre4
Damien Stuart [Sun, 15 Jul 2012 00:54:05 +0000]
Bumped version to 2.0.1-pre4

2 years agoAdded tweaks to ipfw command for Mac OS X
Damien Stuart [Sat, 14 Jul 2012 22:22:42 +0000]
Added tweaks to ipfw command for Mac OS X

2 years agoMerge branch 'master' of ssh://github.com/mrash/fwknop
Damien Stuart [Sat, 14 Jul 2012 14:14:05 +0000]
Merge branch 'master' of ssh://github.com/mrash/fwknop

2 years agoAdded gpg validity check. Tweak to rpm spec file.
Damien Stuart [Sat, 14 Jul 2012 14:13:26 +0000]
Added gpg validity check. Tweak to rpm spec file.

2 years agobumped version to fwknop-2.0.1-pre3 fwknop-2.0.1-pre3
Michael Rash [Fri, 13 Jul 2012 02:19:41 +0000]
bumped version to fwknop-2.0.1-pre3

2 years agoadded libfko.dylib test suite fix note to the ChangeLog
Michael Rash [Fri, 13 Jul 2012 02:18:39 +0000]
added libfko.dylib test suite fix note to the ChangeLog

2 years ago[test suite] Bug fix to account for libfko.dylib extension
Michael Rash [Fri, 13 Jul 2012 02:11:35 +0000]
[test suite] Bug fix to account for libfko.dylib extension

Richard Haas reported the test suite failing on Mac OS X systems with the
existence check for the libfko library.  Damien Stuart advised that the library
has a different extention '.dylib' on Mac OS X, so this change accounts for the

2 years agobumped version to 2.0.1-pre2 fwknop-2.0.1-pre2
Michael Rash [Tue, 10 Jul 2012 02:58:35 +0000]
bumped version to 2.0.1-pre2

2 years agoadded valgrind parsing note
Michael Rash [Tue, 10 Jul 2012 02:39:13 +0000]
added valgrind parsing note

2 years ago[test suite] minor directory path bug fix for --diff mode
Michael Rash [Tue, 10 Jul 2012 02:05:57 +0000]
[test suite] minor directory path bug fix for --diff mode

2 years agoswitched back to older ChangeLog format which is more readable fwknop-2.0.1-pre1
Michael Rash [Tue, 10 Jul 2012 01:29:49 +0000]
switched back to older ChangeLog format which is more readable

2 years agobumped version to 2.0.1-pre1
Michael Rash [Mon, 9 Jul 2012 20:32:10 +0000]
bumped version to 2.0.1-pre1

2 years agoadded dual_key_usage_access.conf to Makefile.am for 'make dist' target
Michael Rash [Mon, 9 Jul 2012 20:30:26 +0000]
added dual_key_usage_access.conf to Makefile.am for 'make dist' target

2 years agoadded unique function names to --enable-valgrind suspect functions test
Michael Rash [Mon, 9 Jul 2012 01:21:36 +0000]
added unique function names to --enable-valgrind suspect functions test

2 years agoadded new test in --enable-valgrind mode to collect suspect functions
Michael Rash [Sun, 8 Jul 2012 19:30:35 +0000]
added new test in --enable-valgrind mode to collect suspect functions

2 years agoOnly cache replay digests for SPA packets that decrypt
Michael Rash [Sun, 8 Jul 2012 12:36:30 +0000]
Only cache replay digests for SPA packets that decrypt

This change ensures that we only cache replay digests for those SPA packets
that actually decrypt.  Not doing this would have allowed an attacker to
potentially fill up digest cache space with digests for garbage packets.

2 years agoAdded a test for a dual-usage key in access.conf
Michael Rash [Sun, 8 Jul 2012 12:35:50 +0000]
Added a test for a dual-usage key in access.conf

2 years agoBug fix for multi-stanza key use and replay attack detection
Michael Rash [Sun, 8 Jul 2012 01:31:30 +0000]
Bug fix for multi-stanza key use and replay attack detection

This commit fixes a bug where the same encryption key used for two stanzas in
the access.conf file would result in access requests that matched the second
stanza to always be treated as a replay attack.  This has been fixed for
the fwknop-2.0.1 release, and was reported by Andy Rowland.  Now the fwknopd
server computes the SHA256 digest of raw incoming payload data before
decryption, and compares this against all previous hashes.  Previous to this
commit, fwknopd would add a new hash to the replay digest list right after
the first access.conf stanza match, so when SPA packet data matched the
second access.conf stanza a matching replay digest would already be there.

2 years agogcc warning fix fox: fko_decode.c:43:17: warning: variable ‘edata_size’ set but not...
Michael Rash [Mon, 28 May 2012 18:22:33 +0000]
gcc warning fix fox: fko_decode.c:43:17: warning: variable ‘edata_size’ set but not used [-Wunused-but-set-variable]

2 years agoupdated PF anchor check to not rely on listing the PF policy
Michael Rash [Mon, 28 May 2012 18:19:52 +0000]
updated PF anchor check to not rely on listing the PF policy

2 years agoadded Ted Wynnychenko for OpenBSD PF testing
Michael Rash [Mon, 28 May 2012 18:18:34 +0000]
added Ted Wynnychenko for OpenBSD PF testing

3 years agoconvert Rijndael blocksize values '16' to use RIJNDAEL_BLOCKSIZE macro
Michael Rash [Sun, 15 Jan 2012 20:57:45 +0000]
convert Rijndael blocksize values '16' to use RIJNDAEL_BLOCKSIZE macro

3 years agoadded --stat output to ChangeLog fwknop-2.0 fwknop-2.0
Michael Rash [Mon, 2 Jan 2012 23:35:41 +0000]
added --stat output to ChangeLog

3 years agomoved ChangeLog-v2.0 to ChangeLog
Michael Rash [Mon, 2 Jan 2012 23:33:42 +0000]
moved ChangeLog-v2.0 to ChangeLog

3 years agoremoved old ChangeLog files
Michael Rash [Mon, 2 Jan 2012 23:32:35 +0000]
removed old ChangeLog files

3 years agoAdded ChangeLog, ShortLog, and diffstat files for the 2.0 release.
Michael Rash [Mon, 2 Jan 2012 23:26:05 +0000]
Added ChangeLog, ShortLog, and diffstat files for the 2.0 release.

3 years agobumped version to 2.0
Michael Rash [Mon, 2 Jan 2012 22:47:01 +0000]
bumped version to 2.0

3 years agoadded FKO_CHECK_COMPILER_ARG_LDFLAGS_ONLY to fix ro-relocations and immediate binding...
Michael Rash [Mon, 2 Jan 2012 20:26:42 +0000]
added FKO_CHECK_COMPILER_ARG_LDFLAGS_ONLY to fix ro-relocations and immediate binding protection compliation warnings on FreeBSD

3 years agominor test suite update to look for linker warnings in a more generic way
Michael Rash [Mon, 2 Jan 2012 20:25:35 +0000]
minor test suite update to look for linker warnings in a more generic way

3 years agominor test suite addition to check for linker input file warnings
Michael Rash [Mon, 2 Jan 2012 20:10:55 +0000]
minor test suite addition to check for linker input file warnings

3 years agobumped version to 2.0
Michael Rash [Mon, 2 Jan 2012 16:29:16 +0000]
bumped version to 2.0

3 years agominor wording update subversion -> git
Michael Rash [Mon, 2 Jan 2012 14:53:36 +0000]
minor wording update subversion -> git

3 years agoRefactored configure.ac to use a custom macro for compiler flag checks.
Damien S. Stuart [Thu, 29 Dec 2011 19:19:16 +0000]
Refactored configure.ac to use a custom macro for compiler flag checks.
Set version to 2.0 (non-release candidate).
Minor typo fixes.

3 years agoupdated copyright and license statement - fwknop is GPL software
Michael Rash [Tue, 13 Dec 2011 01:41:39 +0000]
updated copyright and license statement - fwknop is GPL software

3 years agominor addition of the local_spa.key file for 'make dist' fwknop-2.0rc5 fwknop-2.0rc5
Michael Rash [Tue, 6 Dec 2011 03:23:00 +0000]
minor addition of the local_spa.key file for 'make dist'

3 years agoadded local_spa.key file
Michael Rash [Tue, 6 Dec 2011 03:21:31 +0000]
added local_spa.key file

3 years agoadded local_spa.key file
Michael Rash [Tue, 6 Dec 2011 03:20:39 +0000]
added local_spa.key file

3 years agominor addition of the CREDITS file for 'make dist'
Michael Rash [Tue, 6 Dec 2011 03:16:38 +0000]
minor addition of the CREDITS file for 'make dist'

3 years agoAdded the CREDITS file for 'make dist'
Michael Rash [Tue, 6 Dec 2011 03:16:03 +0000]
Added the CREDITS file for 'make dist'

3 years agochange log doc updates
Michael Rash [Tue, 6 Dec 2011 03:11:58 +0000]
change log doc updates

3 years agoAdded various files to Makefile.am so that 'make dist' continues to work
Michael Rash [Tue, 6 Dec 2011 03:10:47 +0000]
Added various files to Makefile.am so that 'make dist' continues to work

3 years agoadded CREDITS file, bumped software version, added ChangeLog files
Michael Rash [Tue, 6 Dec 2011 02:14:31 +0000]
added CREDITS file, bumped software version, added ChangeLog files

3 years agoadded CREDITS file, bumped software version, added ChangeLog files
Michael Rash [Tue, 6 Dec 2011 02:14:14 +0000]
added CREDITS file, bumped software version, added ChangeLog files

3 years agominor compiler warning fix on OpenBSD test_suite
Michael Rash [Sun, 4 Dec 2011 02:21:29 +0000]
minor compiler warning fix on OpenBSD

3 years agominor compile fixes for FreeBSD
Michael Rash [Sat, 3 Dec 2011 18:10:35 +0000]
minor compile fixes for FreeBSD

3 years agoAdded FORCE_NAT mode to the access.conf file
Michael Rash [Thu, 1 Dec 2011 01:51:19 +0000]
Added FORCE_NAT mode to the access.conf file

This commit adds a new configuration variable "FORCE_NAT" to the access.conf

    For any valid SPA packet, force the requested connection to be NAT'd
    through to the specified (usually internal) IP and port value.  This is
    useful if there are multiple internal systems running a service such as
    SSHD, and you want to give transparent access to only one internal system
    for each stanza in the access.conf file.  This way, multiple external
    users can each directly access only one internal system per SPA key.

This commit also implements a few minor code cleanups.

3 years agominor newline fix for access.conf output dump
Michael Rash [Tue, 29 Nov 2011 04:20:11 +0000]
minor newline fix for access.conf output dump

3 years agomemory leak bugfix as a follow up to commit b280f5cde0246cdef33dee3f8be66a2bcef77336
Michael Rash [Tue, 29 Nov 2011 04:18:07 +0000]
memory leak bugfix as a follow up to commit b280f5cde0246cdef33dee3f8be66a2bcef77336

3 years agoAdded access stanza expiration feature, multiple access stanza bug fix
Michael Rash [Tue, 29 Nov 2011 03:03:21 +0000]
Added access stanza expiration feature, multiple access stanza bug fix

This commit does two major things:

1) Two new access.conf variables are added "ACCESS_EXPIRE" and
"ACCESS_EXPIRE_EPOCH" to allow access stanzas to be expired without having
to modify the access.conf file and restart fwknopd.

2) Allow an access stanza that matches the SPA source address to not
automatically short circuit other stanzas if there is an error (such as when
there are multiple encryption keys involved and an incoming SPA packet is
meant for, say, the second stanza and the first therefore doesn't allow
proper decryption).

3 years agoadded SPA packet aging tests
Michael Rash [Wed, 23 Nov 2011 03:56:48 +0000]
added SPA packet aging tests

3 years agobug fix to exclude SPA packets with timestamps in the future that are too great ...
Michael Rash [Wed, 23 Nov 2011 03:56:36 +0000]
bug fix to exclude SPA packets with timestamps in the future that are too great (old packets were properly excluded already)

3 years agoadded test for --test mode in the fwknop client
Michael Rash [Wed, 23 Nov 2011 03:40:26 +0000]
added test for --test mode in the fwknop client

3 years agobug fix to honor the fwknop client --time-offset-plus and --time-offset-minus options
Michael Rash [Wed, 23 Nov 2011 03:34:10 +0000]
bug fix to honor the fwknop client --time-offset-plus and --time-offset-minus options

3 years agoadded DNAT mode tests, minor memory leak fix in NAT mode, added fwknopd check for...
Michael Rash [Wed, 23 Nov 2011 03:13:27 +0000]
added DNAT mode tests, minor memory leak fix in NAT mode, added fwknopd check for ENABLE_IPT_FORWARDING variable before attempting NAT access

3 years agoadded tests for various access.conf variables
Michael Rash [Sat, 19 Nov 2011 04:23:50 +0000]
added tests for various access.conf variables

3 years agoadded IP/subnet match tests, added --Anonymize-results mode
Michael Rash [Fri, 18 Nov 2011 02:17:50 +0000]
added IP/subnet match tests, added --Anonymize-results mode

3 years agosimplified the client/server interaction code, started on IP filtering tests, added...
Michael Rash [Wed, 16 Nov 2011 02:45:51 +0000]
simplified the client/server interaction code, started on IP filtering tests, added spoof username tests

3 years agominor test wording consolidation
Michael Rash [Fri, 11 Nov 2011 03:54:25 +0000]
minor test wording consolidation

3 years agoThis commit fixes two memory leaks and adds a common exit function.
Michael Rash [Fri, 11 Nov 2011 03:33:32 +0000]
This commit fixes two memory leaks and adds a common exit function.

The two memory leaks were found with the test suite running in
--enable-valgrind mode - here are the relevant error messages:

For fwknopd server GPG clean up:

==345== 9 bytes in 1 blocks are definitely lost in loss record 2 of 2
==345==   at 0x4C2815C: malloc (vg_replace_malloc.c:236)
==345==   by 0x52F6B81: strdup (strdup.c:43)
==345==   by 0x10FA57: add_string_list_ent (access.c:308)
==345==   by 0x110513: parse_access_file (access.c:387)
==345==   by 0x10B5FB: main (fwknopd.c:193)

For fwknop client rc file processing:

==8045== 568 bytes in 1 blocks are still reachable in loss record 12 of 12
==8045==    at 0x4C2815C: malloc (vg_replace_malloc.c:236)
==8045==    by 0x50A53AA: __fopen_internal (iofopen.c:76)
==8045==    by 0x10C3FF: process_rc (config_init.c:446)
==8045==    by 0x10C8F6: config_init (config_init.c:671)
==8045==    by 0x10AC9E: main (fwknop.c:62)

There is also a new clean_exit() function that makes it easier to ensure that
resources are deallocated upon existing.

3 years agoremove CMD timestamps for --diff mode
Michael Rash [Fri, 11 Nov 2011 03:33:00 +0000]
remove CMD timestamps for --diff mode

3 years agoadded --diff mode to the test suite to compare results from one execution to the...
Michael Rash [Sun, 6 Nov 2011 18:51:23 +0000]
added --diff mode to the test suite to compare results from one execution to the next

3 years agoconsolidated several test functions into a single generic_exec() function
Michael Rash [Sat, 5 Nov 2011 03:46:31 +0000]
consolidated several test functions into a single generic_exec() function

3 years agoFixed fwknopd memory leak, several other fixes and updates
Michael Rash [Fri, 4 Nov 2011 02:15:19 +0000]
Fixed fwknopd memory leak, several other fixes and updates

This commit does several things.  First, a memory leak in fwknopd has been
fixed by ensuring to free access.conf stanzas.  This bug was found with the
new test suite running in --enable-valgrind mode.  Here is what some of the
valgrind output looked like to find the leak:

==19217== 11 bytes in 1 blocks are indirectly lost in loss record 3 of 5
==19217==    at 0x4C2815C: malloc (vg_replace_malloc.c:236)
==19217==    by 0x52F6B81: strdup (strdup.c:43)
==19217==    by 0x10FC8B: add_acc_string (access.c:49)
==19217==    by 0x1105C8: parse_access_file (access.c:756)
==19217==    by 0x10B79B: main (fwknopd.c:194)
==19217== 16 bytes in 1 blocks are indirectly lost in loss record 4 of 5
==19217==    at 0x4C27480: calloc (vg_replace_malloc.c:467)
==19217==    by 0x10FEC0: add_source_mask (access.c:88)
==19217==    by 0x110100: expand_acc_source (access.c:191)
==19217==    by 0x1104B0: parse_access_file (access.c:500)
==19217==    by 0x10B79B: main (fwknopd.c:194)
==19217== 183 (152 direct, 31 indirect) bytes in 1 blocks are definitely lost in loss record 5 of 5
==19217==    at 0x4C27480: calloc (vg_replace_malloc.c:467)
==19217==    by 0x1103E4: parse_access_file (access.c:551)
==19217==    by 0x10B79B: main (fwknopd.c:194)
==19217== LEAK SUMMARY:
==19217==    definitely lost: 152 bytes in 1 blocks
==19217==    indirectly lost: 31 bytes in 3 blocks
==19217==      possibly lost: 0 bytes in 0 blocks
==19217==    still reachable: 8 bytes in 1 blocks
==19217==         suppressed: 0 bytes in 0 blocks

Second, this commit changes how fwknopd acquires packet data with
pcap_dispatch() - packets are now processed within the callback function
process_packet() that is provided to pcap_dispatch(), the global packet
counter is incremented by the return value from pcap_dispatch() (since this is
the number of packets processed per pcap loop), and there are two new
fwknopd.conf variables PCAP_DISPATCH_COUNT and PCAP_LOOP_SLEEP to control the
number of packets that pcap_dispatch() should process per loop and the number
of microseconds that fwknopd should sleep per loop respectively.  Without this
change, it was fairly easy to cause fwknopd to miss packets by creating bursts
of packets that would all be processed one at time with the usleep() delay
between each.  For fwknopd deployed on a busy network and with a permissive
pcap filter (i.e. something other than the default that causes fwknopd to look
at, say, TCP ACK's), this change should help.

Third, the criteria that a packet must reach before data copying into the
buffer designed for SPA processing has been tightened.  A packet less than
/greater than the minimum/maximum expected sizes is ignored before data is
copied, and the base64 check is done as well.

3 years agoadded complete SPA cycle tests for tcp ports 23 and 9418 (git), and for udp 53 dns
Michael Rash [Mon, 31 Oct 2011 02:14:00 +0000]
added complete SPA cycle tests for tcp ports 23 and 9418 (git), and for udp 53 dns

3 years agoupdated client SPA verbose message to include the server IP/host
Michael Rash [Sun, 30 Oct 2011 03:49:29 +0000]
updated client SPA verbose message to include the server IP/host

3 years agominor looping criteria update for valgrind tests
Michael Rash [Sun, 30 Oct 2011 03:48:42 +0000]
minor looping criteria update for valgrind tests

3 years ago[test-suite] added the ability to run all fwknop tests through valgrind
Michael Rash [Sat, 29 Oct 2011 20:59:57 +0000]
[test-suite] added the ability to run all fwknop tests through valgrind

3 years agobugfix to return preprocess_spa_data() result properly to calling function
Michael Rash [Sat, 29 Oct 2011 20:55:28 +0000]
bugfix to return preprocess_spa_data() result properly to calling function

3 years agoupdate to remove packet direction requirement when sniffing on OpenBSD loopback inter...
Michael Rash [Sat, 29 Oct 2011 03:01:06 +0000]
update to remove packet direction requirement when sniffing on OpenBSD loopback interfaces

3 years agominor whitespace removal
Michael Rash [Sat, 29 Oct 2011 03:00:26 +0000]
minor whitespace removal

3 years agoadded stack protection detection for OpenBSD systems
Michael Rash [Sat, 29 Oct 2011 02:59:52 +0000]
added stack protection detection for OpenBSD systems

3 years agoUpdate to ensure libfko.so path is detected properly on OpenBSD
Michael Rash [Sat, 29 Oct 2011 02:42:27 +0000]
Update to ensure libfko.so path is detected properly on OpenBSD

3 years agoUpdate to print all firewall commands in --verbose mode
Michael Rash [Fri, 28 Oct 2011 01:51:55 +0000]
Update to print all firewall commands in --verbose mode

This commit makes it easier to determine exactly which commands fwknopd
runs in --verbose mode when interacting with the underlying firewall.
This commit also adds --verbose --verbose mode to the test suite.

3 years agoadded 'const' to function prototype vars where possible
Michael Rash [Wed, 26 Oct 2011 01:00:40 +0000]
added 'const' to function prototype vars where possible

Added the 'const' qualifier to function prototype variables where possible.
In addition, reduced some functions to file-scope with 'static' where possible.

Also made a few minor changes to remove extra whitespace, and fixed a bug
in create_fwknoprc() to ensure the new fwknoprc filehandle is closed.