fwknop.git
3 months ago[test suite] additional client/config_init.c code coverage test for fwknoprc file...
Michael Rash [Sun, 30 Mar 2014 01:44:24 +0000]
[test suite] additional client/config_init.c code coverage test for fwknoprc file parsing

3 months ago[test suite] HTTP proxy tests for client/spa_comm.c test coverage
Michael Rash [Sat, 29 Mar 2014 19:05:52 +0000]
[test suite] HTTP proxy tests for client/spa_comm.c test coverage

3 months ago[test suite] IP resolution tests for client/http_resolve_host.c coverage
Michael Rash [Sat, 29 Mar 2014 18:53:52 +0000]
[test suite] IP resolution tests for client/http_resolve_host.c coverage

3 months ago[client] removed unused hex_dump() function
Michael Rash [Sat, 29 Mar 2014 18:04:09 +0000]
[client] removed unused hex_dump() function

3 months ago[server] fix IP subnet mask CIDR range restriction bug found by Coverity
Michael Rash [Fri, 28 Mar 2014 01:59:30 +0000]
[server] fix IP subnet mask CIDR range restriction bug found by Coverity

3 months ago[libfko] fix memory leak in fko_encode_spa_data() caught by Coverity
Michael Rash [Fri, 28 Mar 2014 01:21:17 +0000]
[libfko] fix memory leak in fko_encode_spa_data() caught by Coverity

3 months ago[libfko] Memory leak bug fix in GnuPG handling
Michael Rash [Thu, 27 Mar 2014 01:14:11 +0000]
[libfko] Memory leak bug fix in GnuPG handling

Bug fix to correct a memory leak in GnuPG SPA packet handling within
the gpg_decrypt() function.  Here is the specific valgrind leak record
that enabled the bug to be found (note that the new valgrind
suppressions usage was critical for finding this bug among all other
libgpgme memory leaks):

==23983== 1,044 bytes in 1 blocks are definitely lost in loss record 7 of 8
==23983==    at 0x4C2C494: calloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==23983==    by 0x4E41D3A: gpg_decrypt (fko_encryption.c:422)
==23983==    by 0x4E42520: fko_decrypt_spa_data (fko_encryption.c:626)
==23983==    by 0x1155B0: incoming_spa (incoming_spa.c:519)
==23983==    by 0x1180A7: process_packet (process_packet.c:211)
==23983==    by 0x506D857: ??? (in /usr/lib/x86_64-linux-gnu/libpcap.so.1.4.0)
==23983==    by 0x117865: pcap_capture (pcap_capture.c:270)
==23983==    by 0x10F937: main (fwknopd.c:353)

3 months ago[test suite] Added valgrind suppressions for gpgme
Michael Rash [Thu, 27 Mar 2014 00:51:10 +0000]
[test suite] Added valgrind suppressions for gpgme

Running the test suite with --enable-valgrind resulted in large numbers
of leaks detected in gpgme functions.  This commit adds a valgrind
suppressions file to squash these errors (which are not fwknop's fault),
and also enables the valgrind --child-slient-after-fork option by
default.  Both of these can disable in test suite execution with two
new options: --valgrind-disable-suppressions and
--valgrind-disable-child-silent.

3 months ago[client+server] verify GnuPG signatures by default
Michael Rash [Thu, 20 Mar 2014 03:12:01 +0000]
[client+server] verify GnuPG signatures by default

- [server] When GnuPG is used, the default now is to require that
incoming SPA packets are signed by a key listed in GPG_REMOTE_ID for each
access.conf stanza. In other words, the usage of GPG_REQUIRE_SIG
is no longer necessary in order to authenticate SPA packets via the
GnuPG signature. Verification of GnuPG signatures can be disabled with a
new access.conf variable GPG_DISABLE_SIG, but this is NOT a
recommended configuration.
- [client+server] Add --gpg-exe command line argument and GPG_EXE
config variable to ~/.fwknoprc and the access.conf file so that the path
to GnuPG can be changed from the default /usr/bin/gpg path.

4 months ago[test suite] don't remove .gcov/.gcda profiling files in --list-mode
Michael Rash [Wed, 19 Mar 2014 00:39:25 +0000]
[test suite] don't remove .gcov/.gcda profiling files in --list-mode

4 months ago[test suite] exercise fko_base64_encode() and fko_base64_decode() in fko-wrapper
Michael Rash [Wed, 19 Mar 2014 00:37:47 +0000]
[test suite] exercise fko_base64_encode() and fko_base64_decode() in fko-wrapper

4 months ago[test suite] add --spoof-user test
Michael Rash [Tue, 18 Mar 2014 02:36:49 +0000]
[test suite] add --spoof-user test

4 months ago[test suite] add --preserve-previous-profile-files
Michael Rash [Tue, 18 Mar 2014 02:36:17 +0000]
[test suite] add --preserve-previous-profile-files

4 months agofor --enable-profile-coverage add -lgcov to LDFLAGS and remove -O0 optimization switch
Michael Rash [Tue, 18 Mar 2014 02:07:42 +0000]
for --enable-profile-coverage add -lgcov to LDFLAGS and remove -O0 optimization switch

4 months ago[extras] allow configure wrapper to pass on args to the configure script
Michael Rash [Tue, 18 Mar 2014 02:06:31 +0000]
[extras] allow configure wrapper to pass on args to the configure script

4 months agofix automake subdir-objects warning on Mac OS X, fixes part of #115
Michael Rash [Tue, 18 Mar 2014 02:05:45 +0000]
fix automake subdir-objects warning on Mac OS X, fixes part of #115

4 months ago[test suite] ensure the fko multi-call wrapper is executed under valgrind
Michael Rash [Tue, 18 Mar 2014 01:43:36 +0000]
[test suite] ensure the fko multi-call wrapper is executed under valgrind

4 months ago[test suite] add lcov html results for gcov profile coverage in --enable-profile...
Michael Rash [Tue, 18 Mar 2014 01:42:31 +0000]
[test suite] add lcov html results for gcov profile coverage in --enable-profile-coverage mode

4 months ago[libfko] per-SPA message type field count validation
Michael Rash [Mon, 17 Mar 2014 01:47:19 +0000]
[libfko] per-SPA message type field count validation

This commit implements more rigorous SPA packet field count validation
that takes into account expected field counts for each SPA message type.
Two new libfko error codes have been added in support of this, and the
corresponding changes made in the perl and python modules.

4 months ago[libfko] minor error constant label typo fix
Michael Rash [Sun, 16 Mar 2014 20:37:21 +0000]
[libfko] minor error constant label typo fix

4 months ago[test suite] minor bug fix to add udpraw mode for spoofed src test
Michael Rash [Sun, 16 Mar 2014 13:11:31 +0000]
[test suite] minor bug fix to add udpraw mode for spoofed src test

4 months ago[libfko] dedicated parsing functions for decoding client timeout and server auth...
Michael Rash [Sun, 16 Mar 2014 13:08:33 +0000]
[libfko] dedicated parsing functions for decoding client timeout and server auth SPA fields

4 months agoreplace malloc() with calloc() calls
Michael Rash [Sun, 16 Mar 2014 02:02:57 +0000]
replace malloc() with calloc() calls

4 months ago[libfko] add digest verification and length fcns to decode routine
Michael Rash [Sun, 16 Mar 2014 01:37:30 +0000]
[libfko] add digest verification and length fcns to decode routine

4 months agoChangeLog updates for 2.6.1
Michael Rash [Sat, 15 Mar 2014 03:08:34 +0000]
ChangeLog updates for 2.6.1

4 months agoMerge branch 'ms_compatible_usernames'
Michael Rash [Sat, 15 Mar 2014 03:02:47 +0000]
Merge branch 'ms_compatible_usernames'

This merges in work on #114 to allow MS compatible usernames, and should
help Cygwin (and Windows) users.

4 months agoMerge branch 'master' of https://github.com/mrash/fwknop
Michael Rash [Sat, 15 Mar 2014 02:57:53 +0000]
Merge branch 'master' of https://github.com/mrash/fwknop

4 months ago[libfko] call SPA field parsers via function pointers in fko_decode_spa_data()
Michael Rash [Sat, 15 Mar 2014 02:57:36 +0000]
[libfko] call SPA field parsers via function pointers in fko_decode_spa_data()

4 months ago[libfko] start on refactoring fko_decode_spa_data() to put SPA field parsing into...
Michael Rash [Fri, 14 Mar 2014 23:21:33 +0000]
[libfko] start on refactoring fko_decode_spa_data() to put SPA field parsing into dedicated functions

4 months agoMerge branch 'master' of ssh://github.com/mrash/fwknop
Michael Rash [Fri, 14 Mar 2014 13:16:18 +0000]
Merge branch 'master' of ssh://github.com/mrash/fwknop

4 months agofix header non-ascii chars, and introduce test suite support for detecting this in...
Michael Rash [Wed, 12 Mar 2014 01:29:33 +0000]
fix header non-ascii chars, and introduce test suite support for detecting this in source files

4 months ago[test suite] added Rijndael+HMAC SPOOF_SRC fwknoprc file test
Michael Rash [Thu, 13 Mar 2014 04:10:22 +0000]
[test suite] added Rijndael+HMAC SPOOF_SRC fwknoprc file test

4 months ago[test suite] Added Rijndael+HMAC NAT rand port via client rc file test
Michael Rash [Thu, 13 Mar 2014 03:59:01 +0000]
[test suite] Added Rijndael+HMAC NAT rand port via client rc file test

4 months ago[test suite] Added Rijndael+HMAC command execution test
Michael Rash [Thu, 13 Mar 2014 03:56:12 +0000]
[test suite] Added Rijndael+HMAC command execution test

4 months ago[perl FKO module] comment out username fuzzing packets that are now acceptable to...
Michael Rash [Thu, 13 Mar 2014 03:43:11 +0000]
[perl FKO module] comment out username fuzzing packets that are now acceptable to libfko

4 months ago[test suite] allow fuzzing_spa_packet file comments to skip particular packets
Michael Rash [Thu, 13 Mar 2014 03:41:01 +0000]
[test suite] allow fuzzing_spa_packet file comments to skip particular packets

4 months agofix header non-ascii chars, and introduce test suite support for detecting this in...
Michael Rash [Wed, 12 Mar 2014 01:29:33 +0000]
fix header non-ascii chars, and introduce test suite support for detecting this in source files

4 months ago[libfko] allow MS compatible usernames
Michael Rash [Mon, 10 Mar 2014 03:12:53 +0000]
[libfko] allow MS compatible usernames

Allow usernames that are compatible with Microsoft guidelines as defined
here:

http://technet.microsoft.com/en-us/library/bb726984.aspx

This allows for greater compatibility between fwknop clients on Windows
(for example that may be deployed with Cygwin) and fwknopd on other
systems.  This change was suggested by Gerry Reno, and tracked by Github
issue #114.

4 months agostarted on 2.6.1 ChangeLog entries
Michael Rash [Sun, 9 Mar 2014 23:16:36 +0000]
started on 2.6.1 ChangeLog entries

4 months ago[client] bug fix to set non-zero random source port for UDP raw SPA mode
Michael Rash [Thu, 6 Mar 2014 04:10:47 +0000]
[client] bug fix to set non-zero random source port for UDP raw SPA mode

4 months ago[client] bug fix to convert UDP length header field to network byte order in UDP...
Michael Rash [Thu, 6 Mar 2014 04:11:42 +0000]
[client] bug fix to convert UDP length header field to network byte order in UDP raw mode

4 months ago[test suite] establish new test.log file in --list mode
Michael Rash [Fri, 7 Mar 2014 04:52:56 +0000]
[test suite] establish new test.log file in --list mode

4 months ago[test suite] minor --help update to include missed options
Michael Rash [Fri, 7 Mar 2014 04:41:01 +0000]
[test suite] minor --help update to include missed options

4 months agoUpdated authorship and copyright information
Michael Rash [Mon, 3 Mar 2014 03:54:31 +0000]
Updated authorship and copyright information

This commit updates all authorship and copyright information to include a
standard header that references the AUTHORS and CREDITS file. This standard
header was written by the Debian legal team at the request of Franck Joncourt.

4 months ago[server] minor comment typo fix
Michael Rash [Sat, 1 Mar 2014 19:34:20 +0000]
[server] minor comment typo fix

5 months ago[test suite] check for Darwin uname output for Mac OS X
Michael Rash [Mon, 10 Feb 2014 02:39:52 +0000]
[test suite] check for Darwin uname output for Mac OS X

5 months ago[test suite] added git branch and commit values to init
Michael Rash [Fri, 7 Feb 2014 03:20:40 +0000]
[test suite] added git branch and commit values to init

5 months ago[test suite] added portrange bpf filter test
Michael Rash [Fri, 7 Feb 2014 03:12:23 +0000]
[test suite] added portrange bpf filter test

5 months ago[libfko] minor bug fix to not return GPG error codes from _rijndael_decrypt()
Michael Rash [Mon, 3 Feb 2014 01:32:02 +0000]
[libfko] minor bug fix to not return GPG error codes from _rijndael_decrypt()

5 months ago[test suite] buf fix for DYLD_LIBRARY_PATH on Mac OS X systems
Michael Rash [Mon, 3 Feb 2014 01:29:14 +0000]
[test suite] buf fix for DYLD_LIBRARY_PATH on Mac OS X systems

5 months ago[test suite] minor spelling typo fix
Michael Rash [Mon, 3 Feb 2014 01:28:02 +0000]
[test suite] minor spelling typo fix

6 months agoMerge branch 'master' of ssh://10.211.55.11/home/mbr/git/fwknop
Michael Rash [Sun, 19 Jan 2014 04:13:56 +0000]
Merge branch 'master' of ssh://10.211.55.11/home/mbr/git/fwknop

6 months ago[client] minor bug fix to add --spoof-source synonym for --spoof-src to match man...
Michael Rash [Sat, 18 Jan 2014 02:10:36 +0000]
[client] minor bug fix to add --spoof-source synonym for --spoof-src to match man page

6 months ago[test suite] added --client-only mode for the test suite
Michael Rash [Sat, 18 Jan 2014 04:43:11 +0000]
[test suite] added --client-only mode for the test suite

6 months agoadded fwknop.spec update to ChangeLog.git 2.6.0
Michael Rash [Mon, 13 Jan 2014 03:29:04 +0000]
added fwknop.spec update to ChangeLog.git

6 months agoupdated fwknop.spec file release note for 2.6.0
Michael Rash [Mon, 13 Jan 2014 03:27:38 +0000]
updated fwknop.spec file release note for 2.6.0

6 months agoadded Coverity finds/fixes to ChangeLog.git for 2.6.0
Michael Rash [Mon, 13 Jan 2014 02:41:54 +0000]
added Coverity finds/fixes to ChangeLog.git for 2.6.0

6 months ago[server] better checking for read() return value flagged by Coverity
Michael Rash [Mon, 13 Jan 2014 02:40:20 +0000]
[server] better checking for read() return value flagged by Coverity

6 months ago[server] fixed copy-and-paste NULL check bug found by Coverity
Michael Rash [Mon, 13 Jan 2014 02:08:55 +0000]
[server] fixed copy-and-paste NULL check bug found by Coverity

6 months agoadded ChangeLog.git to show changes since 2.5.1
Michael Rash [Sun, 12 Jan 2014 04:33:53 +0000]
added ChangeLog.git to show changes since 2.5.1

6 months agoMerge branch 'master' of https://github.com/mrash/fwknop
Michael Rash [Sat, 11 Jan 2014 20:21:10 +0000]
Merge branch 'master' of https://github.com/mrash/fwknop

6 months agoBumped libfko and protocol versions to 2.0.1. Added dependencies for this version...
Damien Stuart [Sat, 11 Jan 2014 15:58:01 +0000]
Bumped libfko and protocol versions to 2.0.1.  Added dependencies for this version to the fwknop.spec file.

6 months agomerged android4.4_support branch
Michael Rash [Sat, 11 Jan 2014 03:46:54 +0000]
merged android4.4_support branch

6 months ago(Marek Wrzosek) Update docs to reflect random 'digits' use instead of 'bytes' 2.6.0-pre1
Michael Rash [Fri, 3 Jan 2014 01:47:41 +0000]
(Marek Wrzosek) Update docs to reflect random 'digits' use instead of 'bytes'

Suggested doc update to fwknop man pages to accurately describe the usage
of digits instead of bytes for SPA random data.  About 53 bits of entropy
are actually used, although this is in addition to the 64-bit random salt
in for key derivation used by PBKDF1 in Rjindael CBC mode.

6 months agobumped version to 2.6.0
Michael Rash [Thu, 2 Jan 2014 03:27:07 +0000]
bumped version to 2.6.0

6 months ago[libfko] ensure a NULL HMAC key is properly handled
Michael Rash [Thu, 2 Jan 2014 00:45:38 +0000]
[libfko] ensure a NULL HMAC key is properly handled

6 months ago[test suite] minor display_ctx() call position update
Michael Rash [Thu, 2 Jan 2014 00:45:02 +0000]
[test suite] minor display_ctx() call position update

6 months ago[test suite] better loop output for fko-wrapper
Michael Rash [Wed, 1 Jan 2014 19:07:39 +0000]
[test suite] better loop output for fko-wrapper

6 months agominor README update
Michael Rash [Wed, 1 Jan 2014 18:42:13 +0000]
minor README update

6 months ago[libfko] ensure NULL is handled properly for all fko_get_* functions
Michael Rash [Wed, 1 Jan 2014 04:27:05 +0000]
[libfko] ensure NULL is handled properly for all fko_get_* functions

6 months ago[libfko] added NULL check for fko_set_spa_data() data arg
Michael Rash [Tue, 31 Dec 2013 02:56:08 +0000]
[libfko] added NULL check for fko_set_spa_data() data arg

6 months ago[libfko] < 0 checks not needed for size_t vars which are unsigned
Michael Rash [Tue, 31 Dec 2013 02:09:27 +0000]
[libfko] < 0 checks not needed for size_t vars which are unsigned

6 months ago[libfko] enc key NULL checks with fko-wrapper test support
Michael Rash [Mon, 30 Dec 2013 03:44:16 +0000]
[libfko] enc key NULL checks with fko-wrapper test support

6 months ago[libfko] reject negative length values
Michael Rash [Mon, 30 Dec 2013 02:05:04 +0000]
[libfko] reject negative length values

Integer lengths that are negative are never valid.  This commit also
extends the fuzzing capabilities of the test/fko-wrapper code to
validate libfko calls with negative length arguments, and one crash
scenario with a negative length for the encryption key was found (and
fixed) this way.

6 months agoadded fko-wrapper no valgrind script
Michael Rash [Mon, 30 Dec 2013 01:02:56 +0000]
added fko-wrapper no valgrind script

6 months ago[test suite] run fko-wrapper without valgrind, closes #113
Michael Rash [Mon, 30 Dec 2013 00:59:16 +0000]
[test suite] run fko-wrapper without valgrind, closes #113

6 months ago[test suite] use ctx_update() where possible for fko-wrapper
Michael Rash [Sat, 28 Dec 2013 20:22:01 +0000]
[test suite] use ctx_update() where possible for fko-wrapper

6 months ago[test suite] added 'getset' versions of fko_ int/short wrapper functions
Michael Rash [Sat, 28 Dec 2013 19:56:35 +0000]
[test suite] added 'getset' versions of fko_ int/short wrapper functions

6 months ago[test suite] update fko-wrapper to use constants from fko.h
Michael Rash [Sat, 28 Dec 2013 19:20:11 +0000]
[test suite] update fko-wrapper to use constants from fko.h

6 months ago[test suite] added ctx_update() function to fko-wrapper test
Michael Rash [Sat, 28 Dec 2013 19:10:47 +0000]
[test suite] added ctx_update() function to fko-wrapper test

6 months ago[test suite] call FKO functions via function pointers (interim commit)
Michael Rash [Sat, 28 Dec 2013 04:24:05 +0000]
[test suite] call FKO functions via function pointers (interim commit)

6 months ago[android] updated README file, added project/sdk.paths file
Michael Rash [Fri, 27 Dec 2013 01:44:35 +0000]
[android] updated README file, added project/sdk.paths file

6 months ago[android] Added test/conf/hmac_android_access.conf file to Makefile.am android4.4_support
Michael Rash [Tue, 24 Dec 2013 04:16:03 +0000]
[android] Added test/conf/hmac_android_access.conf file to Makefile.am

6 months ago[android] added HMAC test along with non-legacy Rijndael test
Michael Rash [Tue, 24 Dec 2013 04:15:11 +0000]
[android] added HMAC test along with non-legacy Rijndael test

6 months ago[android] added ant.properties file
Michael Rash [Tue, 24 Dec 2013 03:51:26 +0000]
[android] added ant.properties file

6 months ago[android] added project.properties file
Michael Rash [Tue, 24 Dec 2013 03:44:53 +0000]
[android] added project.properties file

6 months ago[android] Makefile.am minor script path update
Michael Rash [Tue, 24 Dec 2013 03:40:18 +0000]
[android] Makefile.am minor script path update

6 months ago[android] update Makefile.am for latest Android directory tree
Michael Rash [Tue, 24 Dec 2013 03:39:21 +0000]
[android] update Makefile.am for latest Android directory tree

6 months ago[android] add HMAC support (currently optional)
Michael Rash [Tue, 24 Dec 2013 03:29:51 +0000]
[android] add HMAC support (currently optional)

6 months ago[android] update to copy fko.h and associated files to jni/fwknop/ via get_libfko_hea...
Michael Rash [Tue, 24 Dec 2013 01:38:04 +0000]
[android] update to copy fko.h and associated files to jni/fwknop/ via get_libfko_header.sh

6 months agoadded Gerry Reno
Michael Rash [Mon, 23 Dec 2013 02:12:26 +0000]
added Gerry Reno

6 months ago[android] applied Gerry Reno's patch for Android-4.4
Michael Rash [Sun, 22 Dec 2013 20:25:32 +0000]
[android] applied Gerry Reno's patch for Android-4.4

6 months agoFix 'string literal' warning for Android client
Michael Rash [Sun, 22 Dec 2013 20:10:23 +0000]
Fix 'string literal' warning for Android client

Under Android-4.4 this commit fixes the following warning:

     [exec] jni/./fwknop/fwknop_client.c: In function 'Java_com_max2idea_android_fwknop_Fwknop_sendSPAPacket':
     [exec] jni/./fwknop/fwknop_client.c:181:5: error: format not a string literal and no format arguments [-Werror=format-security]
     [exec] cc1: some warnings being treated as errors

7 months ago[test suite] bug fix for python FKO extension library path (found on Fedora 19)
Michael Rash [Tue, 17 Dec 2013 03:33:55 +0000]
[test suite] bug fix for python FKO extension library path (found on Fedora 19)

7 months ago[server] fw_initialize() vs. fw_config_init() bug fix for use_masquerade
Michael Rash [Sun, 15 Dec 2013 00:41:00 +0000]
[server] fw_initialize() vs. fw_config_init() bug fix for use_masquerade

7 months ago[server] added FORCE_MASQUERADE to fwknopd(8) man page, closes #101
Michael Rash [Sat, 14 Dec 2013 20:44:39 +0000]
[server] added FORCE_MASQUERADE to fwknopd(8) man page, closes #101

This commit completes the addition of generalized NAT (both DNAT and
SNAT) capabilities to access.conf stanzas.

7 months agoAdded Les Aker to credits file
Michael Rash [Thu, 12 Dec 2013 05:01:44 +0000]
Added Les Aker to credits file

7 months ago[server] pcap_dispatch() packet count default to 100
Michael Rash [Wed, 11 Dec 2013 04:24:39 +0000]
[server] pcap_dispatch() packet count default to 100

Updated pcap_dispatch() default packet count from zero to 100.
This change was made to ensure backwards compatibility with older
versions of libpcap per the pcap_dispatch() man page, and also because
some of a report from Les Aker of an unexpected crash on Arch Linux with
libpcap-1.5.1 that is fixed by this change (closes #110).

7 months ago[test suite] multi-packet pcap test for pcap_dispatch() validation
Michael Rash [Wed, 11 Dec 2013 03:31:03 +0000]
[test suite] multi-packet pcap test for pcap_dispatch() validation

This commit adds a new pcap file to the test suite with an SPA packet after
99 other garbage packets.  This can be used for pcap_dispatch() testing,
though this is not meant to be super instensive - it is just to ensure that
if a PCAP_DISPATCH_COUNT of, say, 10 is selected that the SPA is still seen
by fwknopd.  This commit is in support of #110.

7 months ago[server] use SIGKILL if necessary for -K
Michael Rash [Tue, 10 Dec 2013 04:10:46 +0000]
[server] use SIGKILL if necessary for -K

This change sends SIGKILL to fwknopd under -K if SIGTERM does not do the job
first.  This can be necessary in some cases if libpcap does not properly handle
a packet count of zero in pcap_dispatch() (see github issue #110).  On a side
note, the default packet dispatch count of zero will likely be changed because
of that issue too.